Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOB-9249 - Android 15 upgrade #811

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Ayyanchira
Copy link
Member

@Ayyanchira Ayyanchira commented Sep 30, 2024

🔹 Jira Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

“Akshay and others added 19 commits July 18, 2024 10:50
Bumping compileSDK version to 35 and Tester app seems to be running okay with it
Build Gradle - Version updates to mocktio, mockwebserver, mockito-android to app & api build.gradle files.
minifyEnabled on - app, api, & api-ui and sample app build.gradle as well
kotlin jdk 7 to 8 update on api and api-ui
gradle build update from 8.5.1 to 8.5.2 on project build gradle

Test method server request now includes max wait of 5 seconds for each test. Looked like a sweet spot to avoid flakiness.
isNull do not need parameters. Modifying those.
Embedded Mock manager removal.
Embedded tests are confirmed to work
Allowing online request processor to run the execution on executor, allowing for async approach.
Offline request processor is untouched and will follow the Tasks one by one as it might need to stop processing if one of them fails and avoid data loss.
This approach seems not harmful for online request processor
When targeting newer SDK, Api Requests Tests fails. non https requests were not getting checked. Hence clear test allowance
NotificationTest were failing. Required permission to post notification
Added a note in ignoring annotation for taking a look later.
No specific reason. Android studio suggestions. No regression.
This is an effort to make the test of button with action with remote inputs be mutable.
The tests are all passing. But I am also feeling, whether to mark pendingIntent as Mutable or Immutable can be decided based on if a mutable intent is required. Remote input might require mutable intent as the data from keyboard could change the intent. But may be not other buttons which do not necessarily open the app. But providing mutable doesnt cause big harm is what Im thinking.
Bumping targetSDK version to 29
Now buttons not opening the app will have mutable intent
@Ayyanchira Ayyanchira requested a review from vbabenkoru November 8, 2024 18:28
Compile SDK to 34 across everything

Target SDK raised in api and api-ui to 32
minSDK version is now 21 across everything. This change perhaps came from another branch. We had already bumped minSDK version before. Or perhaps only app build.gradle was updated before!

Dependencies updates:
Test runner, test rules, espresso, junit, uiauomator updated in api build gradle

ApiResponseTest class - timeout increase helps run the test consistently ok.

NotificationTest class - Ignoring a image checking method. Not allowing to pass null in bigPictureIcon. removing the line in code also doesnt pass the test. Hence ignoring this method. From api- builder class, removed the line which sets bigLargeIcon to null.

EmbeddedView now uses new ways to setbackground instead of deprecated setBackgroundDrawable method.
@Ayyanchira Ayyanchira force-pushed the chore/android15-compatibility branch from 4d951e8 to 3142bb6 Compare November 8, 2024 20:01
“Akshay and others added 5 commits November 8, 2024 13:29
This is a temporary change and SDK should have this in place to keep quality in check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant